Add support for account format v2 in util check-storage
#6977
Conversation
Currently, the `storage-health` command only supports account storage format v1. However, we need to also support the recently added v2. This commit adds two flags to check storage health of account format (v1 or v2). - "account-format-v1" flag should be on if state contains any accounts in v1 format - "account-format-v2" flag should be on if state contains any accounts in v2 format Both flags should be specified if both v1 and v2 are present in the state.
fxamacker
changed the title
storage-health for account format v1 & v2storage-health
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6977 +/- ##
=======================================
Coverage 41.10% 41.11%
=======================================
Files 2127 2127
Lines 186321 186278 -43
=======================================
- Hits 76586 76581 -5
+ Misses 103308 103275 -33
+ Partials 6427 6422 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I found old concurrency code in Fixed it with stop-gap code for now and will push the fix into this PR after testing it on gcp with account format v2. I have a bad cold since early morning, so if test run on gcp doesn't finish soon (by around 9 PM Central) then I will push the fix tomorrow morning after confirming it worked. |
The old concurrency code is incompatible with the new account format v2 which uses a single map for account data. As a stop-gap, this commit removes the incompatible concurrency code.
fxamacker
changed the title
storage-healthcheck-storage
It ran fine on gcp so commit 740377b was pushed last night. We can merge this PR (unless there is a bug). If needed, we can open a separate PR to optimize |
Currently,
utilprogram'scheck-storagecommand (to check storage health) only supports account storage format v1. However, we need to also support the recently added v2.This commit adds two flags to check storage health of account format (v1 or v2).
account-format-v1flag should be on if state contains any accounts in v1 formataccount-format-v2flag should be on if state contains any accounts in v2 formatIMPORTANT: Both flags should be specified if both v1 and v2 are present in the state (e.g. during zero-downtime migration to account storage format v2 before all accounts finish migrating).