Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network] upgrade libp2p and libp2p-pubsub libraries - v0.37 #6978

Closed
wants to merge 7 commits into from

Conversation

peterargue
Copy link
Contributor

@peterargue peterargue commented Feb 4, 2025

Backports: #6963

This PR also pulls in these PRs from master which were needed to get tests passing
#6822
#6917

@peterargue peterargue requested a review from a team as a code owner February 4, 2025 23:55
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 39.43662% with 43 lines in your changes missing coverage. Please review.

Project coverage is 40.96%. Comparing base (371b754) to head (e6001d3).

Files with missing lines Patch % Lines
network/p2p/mock/node_builder.go 0.00% 13 Missing ⚠️
network/p2p/test/fixtures.go 12.50% 6 Missing and 1 partial ⚠️
engine/access/rpc/connection/node_mock.go 71.42% 4 Missing and 2 partials ⚠️
network/p2p/builder/libp2pNodeBuilder.go 0.00% 6 Missing ⚠️
network/p2p/builder/gossipsub/gossipSubBuilder.go 16.66% 4 Missing and 1 partial ⚠️
network/p2p/mock/gossip_sub_builder.go 0.00% 2 Missing ⚠️
network/p2p/mock/pub_sub_adapter_config.go 0.00% 2 Missing ⚠️
network/p2p/node/gossipSubAdapterConfig.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            v0.37    #6978      +/-   ##
==========================================
- Coverage   41.44%   40.96%   -0.49%     
==========================================
  Files        2036     1989      -47     
  Lines      181791   176770    -5021     
==========================================
- Hits        75344    72408    -2936     
+ Misses     100204    98390    -1814     
+ Partials     6243     5972     -271     
Flag Coverage Δ
unittests 40.96% <39.43%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Access] Fix mocking in connection unittests
[Access] Fix access connection tests for latest version of testing library
@peterargue
Copy link
Contributor Author

we're not going to upgrade the v0.37 network, and instead wait for the v0.38 upgrade

@peterargue peterargue closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants