Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests: BooleanField, ArrayField #12

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

lealobanov
Copy link
Collaborator

@lealobanov lealobanov commented Jan 30, 2024

Description

Unit tests for:

com.nftco.flow.sdk.cadence.BooleanField;
com.nftco.flow.sdk.cadence.ArrayField;

  • Updated ArrayField hashCode() method for tests to succeed; hash codes returned for Arrays using existing method were not equal.

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@lealobanov lealobanov changed the title Add tests for BooleanField (WIP) Unit tests: BooleanField, ArrayField Jan 30, 2024
Copy link

github-actions bot commented Jan 30, 2024

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5e9b18a. ± Comparison against base commit 5e9b18a.

♻️ This comment has been updated with latest results.

@lealobanov lealobanov changed the title (WIP) Unit tests: BooleanField, ArrayField Unit tests: BooleanField, ArrayField Jan 30, 2024
@lealobanov lealobanov marked this pull request as ready for review January 30, 2024 10:47
@franklywatson franklywatson merged commit 5e9b18a into main Jan 30, 2024
0 of 2 checks passed
@franklywatson franklywatson deleted the field-array-boolean-test branch January 30, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants