Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ITs for JSON Cadence parser #35

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Conversation

lealobanov
Copy link
Collaborator

@lealobanov lealobanov commented Mar 6, 2024

Description

  • Add integration tests for untested classes in JSON Cadence serializer/deserializer

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link

github-actions bot commented Mar 6, 2024

Unit Test Results

  51 files  ±0    51 suites  ±0   7s ⏱️ ±0s
275 tests ±0  275 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4075fe5. ± Comparison against base commit 4075fe5.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 6, 2024

Integration Test Results

  7 files  ±0    7 suites  ±0   30s ⏱️ ±0s
33 tests ±0  33 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4075fe5. ± Comparison against base commit 4075fe5.

♻️ This comment has been updated with latest results.

@lealobanov lealobanov changed the title (WIP) Add missing ITs for JSON Cadence parser Add missing ITs for JSON Cadence parser Mar 6, 2024
@lealobanov lealobanov marked this pull request as ready for review March 6, 2024 10:22
@franklywatson
Copy link
Contributor

The tests ran locally but seems to fail in the CI here. I approved in the meanwhile.

@lealobanov
Copy link
Collaborator Author

lealobanov commented Mar 7, 2024

@franklywatson yes, I noticed that the tests running against the network tend to throw "max rate exceeded" after running through the CI pipeline 2-3 times. I noticed the rate limit usually resets after 12-24 hours and then they are able to run again normally (just retriggered on this branch and they ran successfully)... not sure if we could do anything on our side to remove the request limit (could it be tied to the IP address of the Github VM used to run the tests?)

@franklywatson franklywatson merged commit 4075fe5 into main Mar 7, 2024
3 checks passed
@franklywatson franklywatson deleted the integration-tests branch March 7, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants