Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ux): Use opacity to make the focused pane more obvious #2503

Merged
merged 7 commits into from
Sep 28, 2020

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Sep 23, 2020

With all the vim-navigation pieces we're adding, it can be hard to follow where focus is going, and get nice visual feedback to confirm the gesture behaved as the user intended.

This uses opacity to help draw the eye, in a subtle way, to changes in focus:

2020-09-23 13 26 20

Depends on revery-ui/revery#1002

@pmizio
Copy link

pmizio commented Sep 23, 2020

Hi @bryphe! Awesome feat. I shoot idea of config value for opacity strength would be very nice 👍

@bryphe
Copy link
Member Author

bryphe commented Sep 25, 2020

Hi @miziak ! Sure, that's a good idea - I added an oni.inactiveWindowOpacity setting:

2020-09-25 15 40 37

Setting to 1.0 will disable the effect.

@bryphe bryphe merged commit bcc964c into master Sep 28, 2020
@bryphe bryphe deleted the feat/ux/focused-opacity branch September 28, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants