Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V0.8 #164

Merged
merged 69 commits into from
Jun 21, 2024
Merged

V0.8 #164

merged 69 commits into from
Jun 21, 2024

Conversation

anoek
Copy link
Member

@anoek anoek commented Jun 14, 2024

This branch will become the start of v0.8, which is focused around adding a number of scoring updates and refactoring the code base to better segregate our backend and front end logic, normalize nomenclature, and de-duplicate code as we march towards a v1.0 release.

The scoring updates include:

  • Switches our scorer to use https://github.com/lightvector/goscorer which does automatic dame detection and proper seki scoring for Japanese rules
  • Adds support for highlighting locations that need sealing before proper scoring can be done
  • Alters the toggling of dead stones in the stone removal phase to make it less error prone
  • Removes the ability to manually flag locations as dame. Moving forward if there is a problem with dame detection, it's considered a bug.
  • Adds a red X to removed stones for clarity

image

  • Adds support for marking scores and dead stones in analysis and reviews

image

image

anoek added 30 commits June 3, 2024 20:06
@anoek
WIP: Add support for needs sealing markings
4c0351a
@anoek
Sealing logic working with our test cases
a3bf2e3
@anoek
Integrate goscorer and update the stone removal phase code
ca2b00c
@anoek
Fixed up tests
fa31fa5
@anoek
Bump various npm deps
114d42d 
Fixes some errors with node 22
@anoek
Bump typescript
26d91da
@anoek
Update score estimator to use goscorer
5d58d4d
@anoek
Remove GoStoneGroup unused code
17d3287
@anoek
Fixed up tests for score estimator using goscorer
3c2503d
@anoek
Make stone removal in score estimation behave like in stone removal
0500e6e 
phase

Also draw the red x's over the stones like the stone removal phase
@anoek
Fixed tests
6b4162a
@anoek
Remove false eyes from score estimates when using territory scoring
768297c
@anoek
Remove old now unused toggleMetaGroupRemoval from GoEngine
efbd5d6
@anoek
Fix tests
41987b9
@anoek
Add support for score marks in analysis and review mode
d51bebc
@anoek
Support marking dead stones in analysis and reviews
0b0a369
@anoek
Refactor: merge GoUtil.ts and Misc.ts -> util.ts
e913023
@anoek
Refactor: add comments
d52116d
@anoek
Refactoring common board and stone removal behavior to common base class
3f0c445 
GoEngine and ScoreEstimator had essentially the same logic.

This also necessitated some refactoring of our "hook" system, now better
named "callbacks" to be less confusing with react hooks.
@anoek
Refactor: GoStoneGroup -> StoneString
5214b49
@anoek
Fix tests
5137008
@anoek
Refactor: Better stone string nomenclature
2c62b64
@anoek
Rename test file
093cd76
@anoek
Refactor: cleanup and comment
68cf82b
@anoek
Refactor: Moving generic board code from GoEngine to Board
ffd2c6d
@anoek
Comments
5a945a4
@anoek
Refactor: Merged GoEngineState into BoardState
a7b5a62 
Also removed unused udata system we had for GoEngineState
@anoek
Refactor: Specialize isobranch state for move tree, move matrix compa…
0a0e8e9 
…rison code out to util
@anoek
Refactor: rename GobanCore autoScore to performStoneRemovalAutoScorin…
c510809 
…g for clarity
@anoek
Refactor: nomenclature normalization
2c6fbb0
anoek added 19 commits June 15, 2024 16:56
@anoek
Move test specific code to __tests__ directory, use jsdom environment…
55589d2 
… everywhere
@anoek
Move unit tests to dedicated test directory
12cfbb8
@anoek
Add jest.config.ts to tsconfig.json
269fec2
@anoek
Refactor: GoConditionalMove -> ConditionalMoveTree
f642ce5
@anoek
Fix path resolution for ts-node executed manual tests
607ec5d
@anoek
Refactor: coordinate nomenclature normalization
ee215d4
@anoek
Refactor: Split GoMath code into smaller util files
bdaf3d2
@anoek
Refactor: GoEngine -> GobanEngine
8e4b17b
@anoek
Replaced suicide terminology with self capture
e94b499
@anoek
Fixed analysis scoring mode to set by color if the existing color did…
721a5dc 
…n't match the brush color; hoisted out of renders to Goban to de-duplicate.
@anoek
Add mark stashing functions to MoveTree
efa2456
@anoek
Add code duplication detection npm/make target
95203c5
@anoek
Code de-duplication
5d418ac
@anoek
Fixed typing for empty matrix creation
7307ee8
@anoek
Replaced makeStringMatrix with makeMatrix calls. Cleaned up colored s…
9ac475b 
…tone undefined checks
@anoek
Move engine build before with-renderer builds for easier to scan erro…
5edab70 
…r output in my build terminal
@anoek
Code de-duplication
b6ee1a7
@anoek
Fixed analysis scores not being visible after a game was over
334b469
@anoek
v0.8.0-beta.1
39ddc6a
@anoek anoek marked this pull request as ready for review June 17, 2024 14:52
@anoek anoek merged commit b513fb1 into main Jun 21, 2024
1 check passed
@anoek anoek deleted the v0.8 branch June 21, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anoek