Updated game sound logic for case when game ends in a Tie #2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this change is in https://github.com/online-go/goban/ , you'll need to fork that repo and push up a pull request over there, sorry for the trouble. |
|
makes sense, not a problem! |
|
PR is actually : online-go/goban#183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2791
Proposed Changes
-Add a case when game ends in a tie (returns
0instead of a player number)-updates
winnerinterface prop withtieas an optionConcerns
winnerinterface prop be number or string? Where would it be set to be a string? I only saw numbers returned (for player id) but not sure when a string is set.