-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce Runtime's dependence to LLVM #3071
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Chen Tong <[email protected]>
Signed-off-by: Chen Tong <[email protected]>
Signed-off-by: Chen Tong <[email protected]>
Signed-off-by: Chen Tong <[email protected]>
#include "llvm/ADT/SmallString.h" | ||
#include "llvm/Support/ManagedStatic.h" | ||
#include "llvm/Support/Path.h" | ||
#else | ||
#include <algorithm> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: please add // Please no references to LLVM in the else path
just as a reminder that we don't reintroduce dependences on LLVM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those llvm includes are removed because they are replaced with STLs of C++.
Signed-off-by: Chen Tong <[email protected]>
Signed-off-by: Chen Tong <[email protected]>
As a result, the code previous under PYRUNTIME_LIGHT for src/Runtime becomes the default code now.
Now the only source code difference is the float16 support in src/Runtime/python. There are too much code to copy from llvm. Low priority.