ZHigh to ONNX optimization is default on. Switch flag from enable to disable #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
tungld
reviewed
Feb 13, 2025
| @@ -183,7 +183,7 @@ void addONNXToZHighPasses(mlir::PassManager &pm) { | |||
| // sub, ...) that are of `stick -> light-weight op -> unstick`, it's better to | |||
| // use CPU instead of NNPA to avoid stick/unstick. CPU is efficient to handle | |||
| // these ops, e.g vectorize the computation. | |||
| if (nnpaEnableZHighToOnnx) | |||
| if (! nnpaDisableZHighToOnnx) | |||
There was a problem hiding this comment.
Looks like the space caused clang-format check failed.
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
|
Jenkins Linux amd64 Build #16291 [push] ZHigh to ONNX optimizati... started at 15:06 |
|
Jenkins Linux s390x Build #16293 [push] ZHigh to ONNX optimizati... started at 16:06 |
|
Jenkins Linux amd64 Build #16291 [push] ZHigh to ONNX optimizati... passed after 1 hr 38 min |
|
Jenkins Linux s390x Build #16293 [push] ZHigh to ONNX optimizati... passed after 2 hr 0 min |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZHigh to ONNX is default on, and should rarely be disabled. Having a compiler flag to explicitly disable it is more intuitive