Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for lightgbm >= 4.0 #634

Merged
merged 11 commits into from
Jul 28, 2023
Merged

Support for lightgbm >= 4.0 #634

merged 11 commits into from
Jul 28, 2023

Conversation

xadupre
Copy link
Collaborator

@xadupre xadupre commented Jul 28, 2023

Fixes issue #632.

Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
@@ -5,15 +5,20 @@
"""
import tempfile
import numpy
import scipy

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'scipy' is not used.
from svm import C_SVC as SVC, EPSILON_SVR as SVR, NU_SVC as NuSVC, NU_SVR as NuSVR
import svmutil
try:
import svm

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'svm' is not used.
@@ -5,15 +5,20 @@
"""
import tempfile
import numpy
import scipy

Check notice

Code scanning / CodeQL

Module is imported with 'import' and 'import from' Note test

Module 'scipy' is imported with both 'import' and 'import from'.
@xadupre xadupre merged commit b4696fb into onnx:main Jul 28, 2023
12 checks passed
xadupre added a commit to xadupre/onnxmltools that referenced this pull request Aug 1, 2023
* Fix issues raised with lightgbm 4.0

Signed-off-by: Xavier Dupre <[email protected]>

* update CI

Signed-off-by: Xavier Dupre <[email protected]>

* remove use of eval

Signed-off-by: Xavier Dupre <[email protected]>

* fix requirements

Signed-off-by: Xavier Dupre <[email protected]>

* update requirements

Signed-off-by: Xavier Dupre <[email protected]>

* fix handle

Signed-off-by: Xavier Dupre <[email protected]>

* fix handle

Signed-off-by: Xavier Dupre <[email protected]>

* fix scipy version

Signed-off-by: Xavier Dupre <[email protected]>

* svm

Signed-off-by: Xavier Dupre <[email protected]>

* remove allow_failure

Signed-off-by: Xavier Dupre <[email protected]>

---------

Signed-off-by: Xavier Dupre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant