ignore hidden files #1405
Merged
ignore hidden files #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidden files are defined here as those beginning with '.' or '_'. This is a departure from previous behavior, where hidden source and test files were evaluated via watch. Evaluating hidden files is undesirable because some editors create hidden temporary files, and these files shouldn't trigger test runs. No flag is added to restore the original behavior at this time as the new behavior is the same as "go test", and it is not expected that it will cause problems. If this change affects you, consider opening a PR to add a CLI flag to restore the previous behavior.
|
This looks great! I’ll pull it in and cut a release once CI goes green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hidden files are defined here as those beginning with '.' or '_'.
This is a departure from previous behavior, where hidden source and test files were evaluated via watch. Evaluating hidden files is undesirable because some editors create hidden temporary files, and these files shouldn't trigger test runs.
No flag is added to restore the original behavior at this time as the new behavior is the same as "go test", and it is not expected that it will cause problems. If this change affects you, consider opening a PR to add a CLI flag to restore the previous behavior.
#1401