Allow interpolation of placeholders in annotation values. #1242
+235
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the possibility of using the `annotate` command to
inject ontology annotations with values derived from the ontology
itself, by substituting placeholders (of the form `%{NAME}`) within the
values provided on the command line.
For now, only two placeholders are supported (`%{ontology_iri}` and
`%{version_iri}`). For that reason, the implementation is very basic,
and is merely a couple of search-and-replace operations.
matentzn
reviewed
Feb 8, 2025
There was a problem hiding this comment.
Very nice code, good function (every ontology we have using ODK would make use of this), two considerations for the design (using flags instead of normal options; the need for the "interpolate" flag), which @jamesaoverton will have to decide / look over.
robot-command/src/main/java/org/obolibrary/robot/AnnotateCommand.java
Outdated
Show resolved
Hide resolved
Most boolean-typed options in ROBOT take a true/false argument instead of being simple flags (whose presence on the command line is enough to enable the option), so we make the new `--interpolate` option of the `annotate` command behave in the same way.
Only conflict was in the CHANGELOG.
jamesaoverton
approved these changes
Mar 5, 2025
|
Thanks for another nice improvement to ROBOT @gouttegd! I marked the two conversations as resolved. Ready for me to merge this? |
|
@jamesaoverton Since you agree with the current behaviour of requesting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves [#1241]
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updatedThis PR implements the proposition outlined in #1241. It adds the possibility of using the
annotatecommand to inject ontology annotations with values derived from the ontology itself, by substituting placeholders (of the form%{NAME}) within the values provided on the command line.For now, only two placeholders are supported (
%{ontology_iri}and%{version_iri}). For that reason, the implementation is very basic, and is merely a couple of search-and-replace operations.