Fixed tomuss parser (we broke it again) #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It couldn't extract the url when it was located in the "empty_is" field (why is it even here ??)
hatch01
reviewed
Oct 15, 2023
There was a problem hiding this comment.
would be better to avoid any type error to modify with something like :
var props = line[id];
if (props is List && props.isNotEmpty)Also we should not print anything in a release version.
So I think the best thing is to do nothing.
we also can throw an error but it will create a cascade crash
|
|
@hatch01 everything should be fine now |
hatch01
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It couldn't extract the url when it was located in the "empty_is" field (why is it even here ??)