Enable milvus version of ChatQnA #1081
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wang, Xigui <[email protected]>
for more information, see https://pre-commit.ci
chensuyue
reviewed
Nov 8, 2024
| @@ -0,0 +1,241 @@ | |||
| # Copyright (C) 2024 Intel Corporation | |||
There was a problem hiding this comment.
Please add an e2e test for this.
|
The PR dependes on 858 Fixed bugs of milvus in retriever and data-prep and adapt milvus on TEI embedding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable milvus version of ChatQnA
Issues
#886
Type of change
Dependencies
No newly introduced 3rd party dependency.
Milvus is in GenAIComps already, but not enabled.
Tests
Verify ChatQnA milvus with UI and RAG functionality.