Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation App - Adding files to deploy Translation application on AMD GPU #1191

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

chyundunovDatamonsters
Copy link
Contributor

Description

Adding files to deploy Translation application on AMD GPU.
Added files:

Translation/docker_compose/amd/gpu/rocm/compose.yaml - Docker compose file for deploy application Translation on AMD GPU
Translation/docker_compose/amd/gpu/rocm/set_env.sh - script for set environments
Translation/docker_compose/amd/gpu/rocm/README.md - readme file for deploying Translation on AMD GPU
Translation/tests/test_compose_on_rocm.sh - script for testing Translation application services on AMD GPU

Issues

It is required to provide the ability to deploy the Translation application based on AMD GPU

Type of change

  • [*] New feature (non-breaking change which adds new functionality)

Dependencies

Tests

Testing was performed manually and by running a script Translation/tests/test_compose_on_amd.sh This script is similar to the script that runs Translation testing on an Intel CPU.

@joshuayao joshuayao added this to the v1.2 milestone Dec 3, 2024
@joshuayao joshuayao linked an issue Dec 3, 2024 that may be closed by this pull request
5 tasks
Copy link
Collaborator

@letonghan letonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chyundunovDatamonsters, thanks for your contribution. Please refer to these review comments and hide the related host_ip/api_tokens.

Translation/docker_compose/amd/gpu/rocm/set_env.sh Outdated Show resolved Hide resolved
Translation/docker_compose/amd/gpu/rocm/set_env.sh Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Dec 17, 2024

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

@chensuyue
Copy link
Collaborator

Please ignore the hyper link check and dockerfile check issue, it will be fixed in #1252

artem-astafev and others added 13 commits December 17, 2024 14:30
Signed-off-by: artem-astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Liang Lv <[email protected]>
Signed-off-by: Chingis Yundunov <[email protected]>
1. Docker Compose file
2. Set envs scripts
3. Tests script
for deploy and tests Translation Application on AMD GPU

Signed-off-by: Chingis Yundunov <[email protected]>
Signed-off-by: Chingis Yundunov <[email protected]>
for more information, see https://pre-commit.ci

Signed-off-by: Chingis Yundunov <[email protected]>
Signed-off-by: minmin-intel <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Chingis Yundunov <[email protected]>
Signed-off-by: Cathy Zhang <[email protected]>
Signed-off-by: Chingis Yundunov <[email protected]>
…sion (opea-project#1171)

Signed-off-by: Mingyuan Qi <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Chingis Yundunov <[email protected]>
Signed-off-by: Wang, Kai Lawrence <[email protected]>
Signed-off-by: Chingis Yundunov <[email protected]>
Delete sensitive data from set envs script

Signed-off-by: Chingis Yundunov <[email protected]>
@chyundunovDatamonsters chyundunovDatamonsters force-pushed the feature/GenAIExample_TranslationApp_deploy_on_AMD_ROCm branch from dc5dfc9 to f87770c Compare December 17, 2024 07:30
@chyundunovDatamonsters
Copy link
Contributor Author

Please tell me why errors occur:

Missing Dockerfile: GenAIComps/comps/retrievers/multimodal/redis/langchain/Dockerfile (Referenced in GenAIExamples/./MultimodalQnA/docker_compose/intel/cpu/xeon/README.md:127)
Missing Dockerfile: GenAIComps/comps/retrievers/multimodal/redis/langchain/Dockerfile (Referenced in GenAIExamples/./MultimodalQnA/docker_compose/intel/hpu/gaudi/README.md:78)

@letonghan
Copy link
Collaborator

letonghan commented Dec 17, 2024

Please tell me why errors occur:

Missing Dockerfile: GenAIComps/comps/retrievers/multimodal/redis/langchain/Dockerfile (Referenced in GenAIExamples/./MultimodalQnA/docker_compose/intel/cpu/xeon/README.md:127) Missing Dockerfile: GenAIComps/comps/retrievers/multimodal/redis/langchain/Dockerfile (Referenced in GenAIExamples/./MultimodalQnA/docker_compose/intel/hpu/gaudi/README.md:78)

It's caused by referring Dockerfiles which have been already deleted.
This issue was fixed by this pr. Please update your branch and run CI tests again.

Chingis Yundunov and others added 4 commits December 18, 2024 10:09
…App_deploy_on_AMD_ROCm' into feature/GenAIExample_TranslationApp_deploy_on_AMD_ROCm
Signed-off-by: Chingis Yundunov <[email protected]>
…App_deploy_on_AMD_ROCm' into feature/GenAIExample_TranslationApp_deploy_on_AMD_ROCm
@xiguiw xiguiw requested a review from ftian1 as a code owner December 20, 2024 06:37
Chingis Yundunov and others added 4 commits December 20, 2024 14:23
…into feature/GenAIExample_TranslationApp_deploy_on_AMD_ROCm
…App_deploy_on_AMD_ROCm' into feature/GenAIExample_TranslationApp_deploy_on_AMD_ROCm
Signed-off-by: Chingis Yundunov <[email protected]>
@xiguiw
Copy link
Collaborator

xiguiw commented Dec 24, 2024

@chyundunovDatamonsters
CI failed.
Would you please help check it?

E2E test with docker compose / example-test (Translation, rocm) / run-test (test_compose_on_rocm.sh) (pull_request_target) Failing after 2m
Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Examples on AMD ROCm for OPEA v1.2