[ChatQNA] Fix K8s Deployment for CPU/HPU #1274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranav Singh <[email protected]>
theBeginner86
requested review from
lvliang-intel,
ftian1 and
chensuyue
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files |
for more information, see https://pre-commit.ci
…hatqna Signed-off-by: Pranav Singh <[email protected]>
…to thebeginner86/chore/chatqna
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes the deployment yamls for ChatQNA in cpu/hpu based k8s clusters.
The issue was with disconnect between the
labelSelectorin chatqna-ui service and labels applied by chatqna-ui deployment to pods. As service would only be able to route the traffic iflabelSelectorhas the exact same match of labels applied to the pods.So keeping consistency with other deployment and services, updates the labels applied to chatqna-ui pods
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.