Add monitoring for rest of ChatQnA + DocSum components #655
+67
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which provide HTTP request metrics. Signed-off-by: Eero Tamminen <[email protected]>
lianhao
approved these changes
Dec 23, 2024
yongfengdu
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ChatQnA + DocSum had few components which provide metrics endpoint, but did not have Prometheus
serviceMonitors for (optional) collection of those metrics. This adds them.Issues
n/a.Type of change
Dependencies
n/a.Tests
Manual testing with
latestimages.Next steps
These components use
MicroServiceclass, so they provide metrics both from that and underlying HTTP service.However, because they don't process any tokens with
MicroService, its metrics are always zero. I'll try to come up with some way to skip exporting them fromMicroServicein "GenAIComps".