[Feature] Added automated provisioning of CosmosDB and App Insights for OPEA applications - Infosys #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kkrishTa <[email protected]>
Signed-off-by: kkrishTa <[email protected]>
Signed-off-by: kkrishTa <[email protected]>
mkbhanda
reviewed
Dec 26, 2024
| indexing_mode = "consistent" | ||
|
|
||
| included_path { | ||
| path = "/*" |
There was a problem hiding this comment.
Does not /* cover everything? Is there some ordering effect here .. from most general to specific?
| name = "workspace-${var.cluster_name}" | ||
| location = azurerm_resource_group.main.location | ||
| resource_group_name = azurerm_resource_group.main.name | ||
| sku = "PerGB2018" |
There was a problem hiding this comment.
Do you really want to hard code sku or keep it a variable?
There was a problem hiding this comment.
sku is not what one might think. PerGB2018 is default, so we should leave it out for simplicity. If needed, we can add it later via variable.
|
@kkrishTa thanks for the PR. I think this is good addition. Few questions below. Can we make CosmosDB optional (opt-in)? User should have an option to include CosmosDB or leave it out. Do we have any OPEA apps using CosmosDB? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Infosys contribution to OPEA.
Added CosmosDB and App Insights to the terraform on Azure.
Issues
NA
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
Tested terraforms on Azure platform.