Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update ns length in klusterlet to 57 #328

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ spec:
namespace:
description: Namespace is the namespace to deploy the agent on the managed cluster. The namespace must have a prefix of "open-cluster-management-", and if it is not set, the namespace of "open-cluster-management-agent" is used to deploy agent. In addition, the add-ons are deployed to the namespace of "{Namespace}-addon". In the Hosted mode, this namespace still exists on the managed cluster to contain necessary resources, like service accounts, roles and rolebindings, while the agent is deployed to the namespace with the same name as klusterlet on the management cluster.
type: string
maxLength: 63
maxLength: 57
pattern: ^open-cluster-management-[-a-z0-9]*[a-z0-9]$
nodePlacement:
description: NodePlacement enables explicit control over the scheduling of the deployed pods.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ spec:
like service accounts, roles and rolebindings, while the agent is
deployed to the namespace with the same name as klusterlet on the
management cluster.
maxLength: 63
maxLength: 57
pattern: ^open-cluster-management-[-a-z0-9]*[a-z0-9]$
type: string
nodePlacement:
Expand Down
2 changes: 1 addition & 1 deletion operator/v1/types_klusterlet.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ type KlusterletSpec struct {
// necessary resources, like service accounts, roles and rolebindings, while the agent
// is deployed to the namespace with the same name as klusterlet on the management cluster.
// +optional
// +kubebuilder:validation:MaxLength=63
// +kubebuilder:validation:MaxLength=57
// +kubebuilder:validation:Pattern=^open-cluster-management-[-a-z0-9]*[a-z0-9]$
Namespace string `json:"namespace,omitempty"`

Expand Down
44 changes: 44 additions & 0 deletions operator/v1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading