Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 simplify the addon progressing message #499

Merged

Conversation

haoqing0110
Copy link
Member

Summary

Related issue(s)

Fixes #

@haoqing0110
Copy link
Member Author

/hold wait for PR open-cluster-management-io/api#335

@haoqing0110
Copy link
Member Author

/assign @qiujian16

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.12%. Comparing base (196bf40) to head (a605986).

Current head a605986 differs from pull request most recent head b2cb246

Please upload reports for the commit b2cb246 to get more accurate results.

Files Patch % Lines
...g/addon/controllers/addonprogressing/controller.go 75.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
- Coverage   62.15%   62.12%   -0.03%     
==========================================
  Files         141      140       -1     
  Lines       11780    11718      -62     
==========================================
- Hits         7322     7280      -42     
+ Misses       3684     3667      -17     
+ Partials      774      771       -3     
Flag Coverage Δ
unit 62.12% <82.60%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoqing0110 haoqing0110 force-pushed the br_addon branch 7 times, most recently from e0faf37 to 3ec0a9d Compare June 6, 2024 09:22
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 7, 2024
Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member

/lgtm

feel free to unhold

@openshift-ci openshift-ci bot added the lgtm label Jun 11, 2024
@haoqing0110
Copy link
Member Author

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 8e792c1 into open-cluster-management-io:main Jun 12, 2024
13 checks passed
@haoqing0110 haoqing0110 deleted the br_addon branch June 12, 2024 01:26
haoqing0110 added a commit to haoqing0110/OCM that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants