Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lapse application endpoint #445

Merged
merged 4 commits into from
Dec 3, 2024
Merged

feat: add lapse application endpoint #445

merged 4 commits into from
Dec 3, 2024

Conversation

yolile
Copy link
Member

@yolile yolile commented Nov 28, 2024

ref #425, will be closed after implementing the changes in the front end

@yolile yolile requested a review from jpmckinney November 28, 2024 15:44
@jpmckinney
Copy link
Member

Looks good, but I thought if status was SUBMITTED then lapsing should only be allowed if the lender uses external onboarding?

Can you update the flow diagram at https://credere.readthedocs.io/en/latest/contributing/index.html ? I think the DB diagram might also be out of date from earlier commits.

@yolile
Copy link
Member Author

yolile commented Nov 29, 2024

Looks good, but I thought if status was SUBMITTED then lapsing should only be allowed if the lender uses external onboarding?

I can be allowed to work with any type of lender, but it will probably be STARTED for lenders without external onboarding. In any case, I can set it to STARTED for all cases (as the button will be on the last page of the application revision form anyway, and the application must be STARTED to get to that page)

Can you update the flow diagram at https://credere.readthedocs.io/en/latest/contributing/index.html ? I think the DB diagram might also be out of date from earlier commits.

Sure

@coveralls
Copy link

coveralls commented Nov 29, 2024

Pull Request Test Coverage Report for Build 12129640509

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 86.377%

Files with Coverage Reduction New Missed Lines %
app/utils/statistics.py 1 92.73%
Totals Coverage Status
Change from base Build 12043847685: 0.01%
Covered Lines: 1788
Relevant Lines: 2070

💛 - Coveralls

@yolile
Copy link
Member Author

yolile commented Dec 2, 2024

@jpmckinney ready for your review again

Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my understanding:

lender lapses the application if the supplier is unresponsive during the review process

Does this mean the lender is contacting the supplier outside the "information requested" loop?

@yolile
Copy link
Member Author

yolile commented Dec 2, 2024

Does this mean the lender is contacting the supplier outside the "information requested" loop?

Yes

@yolile yolile merged commit eaca0f0 into main Dec 3, 2024
10 checks passed
@yolile yolile deleted the 425-lapse-application branch December 3, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants