-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lapse application endpoint #445
Conversation
Looks good, but I thought if status was SUBMITTED then lapsing should only be allowed if the lender uses external onboarding? Can you update the flow diagram at https://credere.readthedocs.io/en/latest/contributing/index.html ? I think the DB diagram might also be out of date from earlier commits. |
I can be allowed to work with any type of lender, but it will probably be STARTED for lenders without external onboarding. In any case, I can set it to STARTED for all cases (as the button will be on the last page of the application revision form anyway, and the application must be STARTED to get to that page)
Sure |
Pull Request Test Coverage Report for Build 12129640509Details
💛 - Coveralls |
@jpmckinney ready for your review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my understanding:
lender lapses the application if the supplier is unresponsive during the review process
Does this mean the lender is contacting the supplier outside the "information requested" loop?
Yes |
ref #425, will be closed after implementing the changes in the front end