Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP site error log #492

Merged
merged 8 commits into from
Apr 30, 2024
Merged

Add PHP site error log #492

merged 8 commits into from
Apr 30, 2024

Conversation

RobHooper
Copy link
Contributor

@RobHooper RobHooper commented Apr 22, 2024

closes #454.

@RobHooper RobHooper requested a review from jpmckinney April 22, 2024 13:37
@RobHooper RobHooper self-assigned this Apr 22, 2024
salt/php-fpm/files/default.conf Show resolved Hide resolved
salt/logrotate/files/php-site-logs Outdated Show resolved Hide resolved
@RobHooper RobHooper linked an issue Apr 22, 2024 that may be closed by this pull request
salt/php-fpm/init.sls Outdated Show resolved Hide resolved
salt/php-fpm/init.sls Outdated Show resolved Hide resolved
salt/php-fpm/files/default.conf Outdated Show resolved Hide resolved
salt/php-fpm/init.sls Outdated Show resolved Hide resolved
salt/php-fpm/init.sls Outdated Show resolved Hide resolved
salt/php-fpm/init.sls Outdated Show resolved Hide resolved
@jpmckinney
Copy link
Member

@RobHooper I see you made commits. Do you intend for me to re-review?

@RobHooper
Copy link
Contributor Author

@RobHooper I see you made commits. Do you intend for me to re-review?

Happy for you to re-review, this PR is ready to deploy from my side.

Once this PR is approved, I will merge and deploy.

jpmckinney added a commit that referenced this pull request Apr 30, 2024
@RobHooper RobHooper merged commit 8857c54 into main Apr 30, 2024
5 checks passed
@RobHooper RobHooper deleted the phplogging branch April 30, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable PHP-FPM error log
2 participants