Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add maintenance code to projectType #493

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Sep 24, 2024

Related issues
closes #237

Description

Merge checklist

If there are changes to project-schema.json or project-package-schema.json:

  • Update the examples:
    • docs/examples/example.json
    • docs/examples/blank.json
  • Run ./manage.py pre-commit to update docs/_static/i8n.csv

If you added a new definition to the schema, run ./manage.py pre-commit.

If you added a new codelist:

  • Add an entry to docs/reference/codelists.md

@odscjen odscjen marked this pull request as ready for review September 24, 2024 14:36
@odscjen
Copy link
Contributor Author

odscjen commented Sep 24, 2024

unable to run manage.py pre-commit as getting an error I don't know how to fix, but ready for review otherwise

@odscjen odscjen requested a review from odscrachel September 24, 2024 14:37
@jpmckinney
Copy link
Member

unable to run manage.py pre-commit as getting an error I don't know how to fix, but ready for review otherwise

Fixed

Copy link
Contributor

@odscrachel odscrachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I had one question though of whether related project should also be updated to include 'maintenance' https://standard.open-contracting.org/infrastructure/latest/en/reference/codelists/#relatedproject

@odscjen odscjen requested a review from jpmckinney September 25, 2024 15:28
@odscjen odscjen merged commit 15dbd85 into 0.9-dev Sep 26, 2024
11 checks passed
@odscjen odscjen deleted the 237-maintenance-code-project-type branch September 26, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add maintenance code to projectType codelist, update code descriptions and add typeDetails field
3 participants