Fixes the grade removing issues in studio. #39
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently we started noticing that the grade page in the studio doesn't have a way to remove grades once you add them.
This is not the default behavior and it happens only when we add custom themes to the platform.
The default behavior is:
grading.mp4
What are we observing:
grading_glitch.mp4
The fix:
grading_fix.mp4
Useful information to include:
Supporting information
Private-ref: BB-9232
open-craft/frontend-app-learning#27
Testing instructions
The instruction can get a bit complicated so I am trying to simplify it as much as possible.
I am trying to test course-authoring-mfe here since that is the mfe which is related to studio.
If you have tutor configured and running redwood:
This will prove that the functionality is working in the platform. Let's configure runtime themeing and see what happens.
cd
into frontend-app-course-authoring and change the branch toasu-moe/redwood-css
since the token support is available in that branch.tutor dev restart lms cms
https://github.com/open-craft/edx-simple-theme
and change the branch to[artur/design-tokens-update](https://github.com/open-craft/edx-simple-theme/tree/artur/design-tokens-update)
npm ci
andnpm run build
inside the repocd dist
and runpython3 -m http.server 9100
farhaan/fix-grading-issue
npm run build
and restart the python server.Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
@xitij2000 can I get a second opinion here from you, I want to know if this is the right way to fix it.