Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: masquerade dropdown not showing current selection (#30) #31

Conversation

kaustavb12
Copy link
Member

Description

Cherry-pick from openedx#1434 and #30

All details including testing instructions can be found there.

Other information

Private Ref : BB-9074

* feat: remove child components from state and use data instead

(cherry picked from commit 2d9807e)

* fix: change active selection based on user input

(cherry picked from commit d72eb23)

* test: add test cases

(cherry picked from commit 59d9db5)
(cherry picked from commit 702c962)
@kaustavb12
Copy link
Member Author

Merging without approval since the changes here has already been approved twice in openedx#1434 and #30.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.48%. Comparing base (cb1a614) to head (3a8c0dd).
Report is 2 commits behind head on asu-moe/redwood-css.

Files with missing lines Patch % Lines
...tor-toolbar/masquerade-widget/MasqueradeWidget.jsx 88.88% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           asu-moe/redwood-css      #31      +/-   ##
=======================================================
+ Coverage                88.77%   89.48%   +0.70%     
=======================================================
  Files                      306      306              
  Lines                     5256     5258       +2     
  Branches                  1336     1302      -34     
=======================================================
+ Hits                      4666     4705      +39     
+ Misses                     573      536      -37     
  Partials                    17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaustavb12 kaustavb12 merged commit 6d98b8b into asu-moe/redwood-css Sep 2, 2024
6 checks passed
@kaustavb12 kaustavb12 deleted the kaustav/fix_masquerade_dropdown_selection_eshe_redwood branch September 2, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant