Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port code drift for open-craft/frontend-app-learning [BB-8367] #7

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

0x29a
Copy link
Member

@0x29a 0x29a commented Dec 28, 2023

Description

This PR ports to Quince three pull requests for this repository, you can find two of them here, and the third one if check the diff between open-release/palm.4 and opencraft-release/palm.1.

Testing notes:

  1. fix: breadcrumb navigation css #4: the dropdown is positioned correctly: image
  2. fix: course update iframe openedx/frontend-app-learning#1204: both short and long update content is handled correctly and as described in the PR testing instructions. NOTE: for some unknown to me reason, this has never been merged to our Palm branch.
  3. feat: legacy course navigation openedx/frontend-app-learning#1239: legacy navigation works as expected. After clicking a breadcrumb, I was redirected and saw this:
    image

navinkarkera and others added 2 commits December 28, 2023 09:50
(cherry picked from commit 0137868)
(cherry picked from commit 657b146)
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (opencraft-release/quince.1@b24568f). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             opencraft-release/quince.1       #7   +/-   ##
=============================================================
  Coverage                              ?   88.09%           
=============================================================
  Files                                 ?      267           
  Lines                                 ?     4544           
  Branches                              ?     1149           
=============================================================
  Hits                                  ?     4003           
  Misses                                ?      527           
  Partials                              ?       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add an option to enable the legacy course navigation where clicking a
breadcrumb leads to the course index page highlighting the selected section.

(cherry picked from commit 2a6b218)
Copy link
Member

@xitij2000 xitij2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: tested on tutor devstack
  • I read through the code

@0x29a 0x29a merged commit 9a1ea93 into opencraft-release/quince.1 Jan 8, 2024
5 checks passed
@0x29a 0x29a deleted the 0x29a/bb8366/quince-shared-branch branch January 8, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants