-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation #1
Open
navinkarkera
wants to merge
27
commits into
main
Choose a base branch
from
navin/block
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navinkarkera
force-pushed
the
navin/block
branch
4 times, most recently
from
July 30, 2024 14:44
b29c8ad
to
a4427ed
Compare
navinkarkera
force-pushed
the
navin/block
branch
from
July 30, 2024 14:48
a4427ed
to
86f4b17
Compare
navinkarkera
force-pushed
the
navin/block
branch
from
July 30, 2024 14:50
86f4b17
to
af054f8
Compare
navinkarkera
force-pushed
the
navin/block
branch
from
July 30, 2024 15:03
101e5aa
to
0361dff
Compare
pkulkark
reviewed
Jul 31, 2024
navinkarkera
force-pushed
the
navin/block
branch
from
July 31, 2024 15:07
65ce424
to
bc60284
Compare
Users are only allowed to go back from test scores slide if display_feedback is set to immediately. If it is set to end_of_test, users cannot go back to the same questions but they can use Redo test button if allow_reset_problems is true.
navinkarkera
force-pushed
the
navin/block
branch
from
August 2, 2024 09:29
79987f5
to
d733533
Compare
Added warning against updating source library id along with fields like display_feedback and showanswer to avoid race condition.
farhaanbukhsh
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good work @navinkarkera
👍
- ✅ I tested this on tutor devstack
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
- ❌ I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository.
To support olive version of edx-platform
pkulkark
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds functionality to display multiple problems randomly selected from a library to the users.
Feature list:
Learner View
Studio View
Supporting information
Private-ref
: BB-8950Private-ref
: Discovery docTesting instructions
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.