Prototyping - move containers into publishing app #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradenmacdonald
force-pushed
the
braden/containers-publishing-merge
branch
from
767329c to
9a4a20e
Compare
bradenmacdonald
force-pushed
the
braden/containers-publishing-merge
branch
from
9a4a20e to
5e78223
Compare
|
Merged into openedx#278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out what happens when we move the
containersmodels intopublishingso that we can be aware of hierarchical relationships when publishing. e.g. so that the PublishLog can include a list of all the containers affected by each publish.This includes a new feature to auto-publish components when a unit is published. But do we want this? The code adds an extra query to every publish.
This seems to cause pylint to crash on my local machine ? But it's passing fine here.