Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changes the Loss of signal from 6min to 10min. #2

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

farhaanbukhsh
Copy link
Member

This change is done to avoid many false alert that is generated and recovers in below 10mins.

JIRA tickets: SE-6314

Discussions: Link to any public dicussions about this PR or the design/architecture. Otherwise omit this.

Dependencies: None

Screenshots: Always include screenshots if there is any change to the UI.

Sandbox URL: TBD - sandbox is being provisioned.

Merge deadline: "None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.

Testing instructions:

The policy is already applied in the new relic dashboard.

This change is done to avoid many false alert that is generated and recovers
in below 10mins.

Signed-off-by: Farhaan Bukhsh <[email protected]>
@itsjeyd
Copy link
Member

itsjeyd commented Nov 28, 2024

@farhaanbukhsh Drive-by question: Does this PR replace #1?

CC @Cup0fCoffee @gabor-boros

@farhaanbukhsh
Copy link
Member Author

@itsjeyd yes :)

@itsjeyd
Copy link
Member

itsjeyd commented Dec 2, 2024

@farhaanbukhsh OK thanks, I closed that one.

CC @Cup0fCoffee @gabor-boros

@farhaanbukhsh
Copy link
Member Author

@itsjeyd thanks :)

@ArturGaspar can you please review this :) cc: @0x29a

@ArturGaspar
Copy link
Member

👍

  • I tested this: Checked the test alerts
  • I read through the code
  • I checked for accessibility issues - N/A
  • Includes documentation
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository. - N/A

@farhaanbukhsh farhaanbukhsh merged commit 5bc70ef into main Dec 9, 2024
2 checks passed
@farhaanbukhsh farhaanbukhsh deleted the farhaan/SE-6314-change-loss-of-signal branch December 9, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants