fix: github ci

open-craft · Aug 7, 2024 · 08547b7 · 08547b7
1 parent 624fe01
commit 08547b7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/.github/workflows/ci-frontend.yml b/.github/workflows/ci-frontend.yml
@@ -14,21 +14,22 @@ jobs:
         working-directory: ./frontend
     strategy:
       matrix:
-        npm-test:
+        npm_script:
         - lint
-        - test
+        - coverage
+        - check-build
     steps:
     - uses: actions/checkout@v4
     - name: Setup Nodejs Env
       run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
-    - uses: actions/setup-node@v2
+    - uses: actions/setup-node@v4
       with:
         node-version: ${{ env.NODE_VER }}
     - run: npm ci
-    - run: npm run lint
-    - run: npm run coverage
+    - run: npm run ${{ matrix.npm_script }}
     - name: upload coverage
       uses: codecov/codecov-action@v4
+      if: matrix.npm_script == 'coverage'
       with:
         token: ${{ secrets.CODECOV_TOKEN }}
         fail_ci_if_error: false

diff --git a/frontend/package.json b/frontend/package.json
@@ -9,6 +9,7 @@
     "build:student": "COMPONENT=student-ui npm run _build",
     "build:studio": "COMPONENT=studio-ui npm run _build",
     "build": "npm run build:studio && npm run build:student",
+    "check-build": "npm run build && git diff --exit-code"
     "lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
     "preview": "vite preview",
     "test": "vitest",