Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: character image in short answer XBlock #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: character image in short answer XBlock #5

wants to merge 1 commit into from

Conversation

ArturGaspar
Copy link
Member

@ArturGaspar ArturGaspar commented Oct 16, 2024 •
edited
Loading

Description

Adds an optional, configurable image to the left of the short answer XBlock, representing a character the learner is dialoguing with.

image

Testing instructions

  1. Set "Character Image URL" in the XBlock settings
  2. See that it works

Other information

Private-ref: https://tasks.opencraft.com/browse/BB-9245

@ArturGaspar ArturGaspar force-pushed the artur/character_image branch 2 times, most recently from 4340876 to 764b2fa Compare November 11, 2024 08:48
@ArturGaspar ArturGaspar force-pushed the artur/character_image branch from 764b2fa to 9091b57 Compare November 11, 2024 08:50
pkulkark
pkulkark approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@pkulkark pkulkark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • I tested this: Verified that the character image shows up in the xblock when set.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkulkark pkulkark pkulkark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArturGaspar @pkulkark