Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow using details and summary HTML tags #87

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

CefBoud
Copy link
Contributor

@CefBoud CefBoud commented Mar 17, 2024

Description

Allows the usage of details and summary HTML tags.

Supporting information

BB-8726

Testing instructions

Create an Xblock and add the following HTML code

<details class="custom-accordion"> <summary> Conflicts of interest</summary> 
Some details. And then some more.
</details>

The HTML tags are escaped.

When using this PR's branch instead, the tags are taken into account.

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.65%. Comparing base (018c36e) to head (29dfd14).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   62.65%   62.65%           
=======================================
  Files           4        4           
  Lines         166      166           
  Branches       15       15           
=======================================
  Hits          104      104           
  Misses         61       61           
  Partials        1        1           
Flag Coverage Δ
unittests 62.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked that the tags are rendered correctly
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository

@Agrendalath Agrendalath merged commit 0d9994c into master Mar 18, 2024
8 checks passed
@Agrendalath Agrendalath deleted the CefBoud/bb-8726/add-details-summary-tags branch March 18, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants