Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designated Queues per Resource Capability #28

Merged
merged 6 commits into from
Jun 17, 2024

Conversation

JVickery-TBS
Copy link

feat(dev): designated queues;

  • Add capability for designated queues per resource.

- Add capability for designated queues per resource.
@JVickery-TBS JVickery-TBS added the enhancement New feature or request label May 24, 2024
@JVickery-TBS JVickery-TBS requested a review from wardi May 24, 2024 13:34
- Added change log file.
@wardi
Copy link
Member

wardi commented May 24, 2024

How does this change worker behaviour?

@JVickery-TBS
Copy link
Author

@wardi It would not change how any of the code is run, it would just put the "load to datastore" job in its own REDIS queue with the name of the Resource ID.

I can add to our forks readme for this.

@wardi
Copy link
Member

wardi commented May 24, 2024

What does putting a job in its own queue do? Just make it easier to report progress on?

@JVickery-TBS
Copy link
Author

@wardi nothing really, you would need to run a worker with that queue like ckan jobs worker <queue name> for it to run. But it allows for creating a swarm service on job workers.

- Added canada fork only changes to readme.
- Added canada fork only changes to readme.
- Added canada fork only changes to readme.
- Added canada fork only changes to readme.
@JVickery-TBS
Copy link
Author

@wardi I have added a new section to the README for our fork, describing some of the main changes of our fork. This includes the new capability for the dedicated queues.

@JVickery-TBS JVickery-TBS merged commit 13c0f39 into canada-v2.9 Jun 17, 2024
1 check passed
@JVickery-TBS JVickery-TBS deleted the feature/resource-id-queue-name branch June 17, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants