Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename OnixDevice::enableDevice() #13

Open
bparks13 opened this issue Feb 4, 2025 · 0 comments · May be fixed by #18
Open

Rename OnixDevice::enableDevice() #13

bparks13 opened this issue Feb 4, 2025 · 0 comments · May be fixed by #18
Assignees
@bparks13
Milestone
Neuropixels 1.0f

Comments

@bparks13
Copy link
Member

bparks13 commented Feb 4, 2025

Conflicting names are in place. There is an enabled boolean which indicates if the device is enabled and should be used when streaming data. This is manipulated via the setEnabled() method. However, there is also a base class method enableDevice() is actually used to configure the device for streaming. For clarity, this should be renamed to something more appropriate, such as configureDevice().
@bparks13 bparks13 added this to the Neuropixels 1.0f milestone Feb 4, 2025
@bparks13 bparks13 self-assigned this Feb 4, 2025
@bparks13 bparks13 linked a pull request Feb 4, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bparks13 bparks13

Labels
None yet
Projects
None yet
Milestone
Neuropixels 1.0f
Development

Successfully merging a pull request may close this issue.

Rename enableDevice open-ephys-plugins/onix-source
1 participant
@bparks13