Remove concurrency restriction #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjsha
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
If we ever want to avoid concurrent actions for a given PR/branch/environment (as opposed to as it was prior to merging this PR which is preventing concurrent actions for all PRs/branches/environments in a repo), we can try something like suggested in this stack overflow post. As of now, I don't see any reason to avoid concurrent actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the actions file, there was a check that did not allow multiple actions to be running concurrently. However, when we have multiple PRs there is a possibility that changes will be pushed to more than one simultaneously leading to one of the actions being prematurely cancelled. This is especially a problem due to how long it takes the actions to run from scratch for the actions.
This PR removes that restriction.