-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Acquisition or Configuration category to public properties #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do a quick review of all these changes and make sure that they comport with my commands on MutliDeviceFactory.Name
? Basically, a property should be marked if its something exposed to the user that changes the behavior of a device at start or start/runtime. Anything outside of that scope should not be marked.
Aside from this, in ConfigureBreakoutAnalogIO
the direction properties are all marked as Acquisition, but should be configuration. Thats left over from when they were settable at runtime and I forgot to change.
- Incorrectly assigned BreakoutAnalogIO properties to Acquisition instead of Configuration category
The remaining thought I have before merging is the members of a I understand the reasoning here, as the properties referred to by the attribute are indeed I think a way around this to define another category defintion
which can be used for member devices of The |
I am in favor of adding My only caveat with adding this category is that @cjsha and I were discussing what to name the headings in the aggregate page (for instance, |
@bparks13 I agree with all. I feel a small force against this because in the ONI standard, |
- For aggregates, use `Devices` category for encapsulated devices
To ensure a consistent user experience across all operators, this PR adds a string to the Category attribute for all public properties that defines the property as
Acquisition
,Configuration
, orDevices
.Configuration
properties are set prior to the start of the workflow. These are not updated in real-time, and are configured once when the workflow starts.Acquisition
properties can have an initial state defined before the workflow begins, but they can be updated in real-time with new values sent to hardware while the workflow is running.Devices
properties are only applicable for aggregates, where this category is applied to each device in an aggregate.