Combine all polled Bno055 classes into common type #303
Conversation
jonnew
commented
Sep 17, 2024
jonnew
commented
- ConfigurePolledBno055 and PolledBno055Data classes replace headstage specific versions of the same thing. Axis map is defined via a couple properties that are not browsable in editor
- Old configuration and data operators are marked obsolete
- Fixes Consolidate passthrough BNO055 configure and data operators #281
commit 7616b9013b43d2cedaf01f2f30a740ad2ec907e8 Author: jonnew <[email protected]> Date: Tue Sep 17 17:11:02 2024 -0400 Add missing Design files - I didn't add these in my last commit commit 760215b Author: jonnew <[email protected]> Date: Tue Sep 17 16:49:30 2024 -0400 Combine all polled Bno055 classes into common type - ConfigurePolledBno055 and PolledBno055Data classes replace headstage specific versions of the same thing. Axis map is defined via a couple properties that are not browsable in editor - Old configuraiton and data operators are marked obsolete
There was a problem hiding this comment.
Looks good, I pulled down the changes and tested on my machine. During testing, I noticed that there were some GUI changes that needed to be made to the GenericDeviceDialog so the buttons did not get clipped. I have added those changes in a new commit, and I also fixed the small nit-picks from my review. Those conversations are closed, there is one outstanding question we should consider, but other than that this PR looks good.
I will say, if someone has an existing workflow containing any of the Neuropixels*Headstage's, they will not be able to save the workflow until they replace the headstage operator with the new one. The reason is because the old headstage operator did not instantiate the AxisMap or the AxisSign variables for the BNO055, therefore the XML serializer will throw an error. I am not sure if this is worth putting any effort into.
- GenericDeviceDialog was not updated to use `TableLayoutPanel` and `FlowLayoutPanel`, so the buttons were getting clipped at different scales. This has been corrected - Typos and whitespace fixes
- This way they can be set if this is used as a standalone device - Add PolledBno055SingleDeviceFactoryConverter to remove them from the properties pane when used in the context of MultiDeviceFactory with a specified orientation - Add correct AxisMap and AxisSign values to obsolete overrides of ConfigurePolledBno055
