Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing configuration to ConfigureUCLAMiniscopeV4Camera #403

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Add missing configuration to ConfigureUCLAMiniscopeV4Camera #403

merged 2 commits into from
Jan 17, 2025

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Jan 17, 2025

  • The ConfigureUCLAMiniscopeV4Camera passthrough configuration assumed that passthrough device registers were defaulted prior to configuring the device to receive miniscope data. If the passthrough device was used for something else (e.g. neuropixels headstage) before this, then this would not be the case. Now we explicitly set all passthrough registers in ConfigureUCLAMiniscopeV4Camera to the correct values.
  • Fixes Miniscope not sending camera data, but can be controlled and IMU sensor data acquired #402

@jonnew
Add missing configuration to ConfigureUCLAMiniscopeV4Camera
02c5c1c 
- The ConfigureUCLAMiniscopeV4Camera passthrough configuration
  assumed that passthrough device registers were defaulted prior
  to configuring the device to receive miniscope data. If the
  passthrough device was used for something else
  (e.g. neuropixels headstage) before this, then this would not
  be the case. Now we explicitly set all passthrough registers in
  ConfigureUCLAMiniscopeV4Camera to the correct values.
@jonnew jonnew requested review from aacuevas and bparks13 January 17, 2025 18:41
aacuevas
aacuevas previously requested changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@aacuevas aacuevas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DS90UB9x.MAGIC should be also set to 0 for safety. Apart from that, seems good.

@jonnew
Configure DS90UB9x.MAGIC to 0 in ConfigureUclaMiniscopeV4Camera
6748c93 
- This was missing in the previous commit
@jonnew
Copy link
Member Author

jonnew commented Jan 17, 2025

Oops, should be good now. @bparks13 I think this is ready

@bparks13 bparks13 requested a review from aacuevas January 17, 2025 21:41
@bparks13 bparks13 merged commit 815c00b into main Jan 17, 2025
8 checks passed
@bparks13 bparks13 deleted the issue-402 branch January 17, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparks13 bparks13 bparks13 approved these changes

@aacuevas aacuevas Awaiting requested review from aacuevas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Miniscope not sending camera data, but can be controlled and IMU sensor data acquired
3 participants
@jonnew @aacuevas @bparks13