-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding OpenFeature provider for AWS AppConfig #310
Open
wani-guanxi
wants to merge
44
commits into
open-feature:main
Choose a base branch
from
wani-guanxi:feature/appconfig-provider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Adding OpenFeature provider for AWS AppConfig #310
wani-guanxi
wants to merge
44
commits into
open-feature:main
from
wani-guanxi:feature/appconfig-provider
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wani-guanxi
changed the title
Feature/appconfig provider
feat: Adding OpenFeature provider for AWS AppConfig
Jan 18, 2025
wani-guanxi
force-pushed
the
feature/appconfig-provider
branch
from
January 18, 2025 16:23
86985c4
to
bf18ec7
Compare
…feature#302) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Ash.Wani <[email protected]>
wani-guanxi
force-pushed
the
feature/appconfig-provider
branch
from
January 21, 2025 18:41
ab70ff4
to
253c92d
Compare
Hey @wani-guanxi, sorry for the delay. I'll try and provide feedback in the next few days. |
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
…uteValue format, as supported by AWS app config. Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
… values Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
…o be supplied at the time of setup Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
… in cache Signed-off-by: Ash.Wani <[email protected]>
Missed updating comments over the course of changes. Fixing that. Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
Signed-off-by: Ash.Wani <[email protected]>
wani-guanxi
force-pushed
the
feature/appconfig-provider
branch
from
January 27, 2025 22:55
ff6a6ae
to
c31db95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adding new project for AWS AppConfig provider implementation for OpenFeature. This allows to manage feature flags using AWS AppConfig.
Notes
Additional details about the package is in Readme file.
Follow-up Tasks
How to test
Testing instructions are available in Readme file under Setup section. Thing to note, this will require AWS account to generate access key and ID in order to talk to AWS AppConfig.