Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add configuration support for target service authority #1413

Conversation

raflFaisal
Copy link

@raflFaisal raflFaisal commented Sep 24, 2024

This PR

Adding a new config option that allows flagd clients to override the authority. This is useful when running gRPC sync service behind proxy e.g. envoy, istio etc. For more details, please refer this PR

  • adds this new feature

Related Issues

open-feature/java-sdk-contrib#949

Notes

Follow-up Tasks

How to test

@raflFaisal raflFaisal requested a review from a team as a code owner September 24, 2024 08:21
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 24, 2024
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for polite-licorice-3db33c ready!

Name Link
🔨 Latest commit a0f3b75
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/66f2767b2d313000089b2e32
😎 Deploy Preview https://deploy-preview-1413--polite-licorice-3db33c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@raflFaisal raflFaisal changed the title Add configuration support for target service authority feat: Add configuration support for target service authority Sep 24, 2024
@raflFaisal raflFaisal changed the title feat: Add configuration support for target service authority Draft: Add configuration support for target service authority Sep 24, 2024
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:

Unknown release type "Draft" found in pull request title "Draft: Add configuration support for target service authority". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@raflFaisal
Copy link
Author

PR is created in forked repo so closing this one

@raflFaisal raflFaisal closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants