fix: support yaml in blob syncs #1522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <[email protected]>
dosubot
bot
added
the
size:L
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
beeme1mr
commented
Jan 17, 2025
Comment on lines
+149
to
+151
| // TODO make consistent with the file sync | ||
| return buf.String(), nil | ||
| // return "", fmt.Errorf("filepath extension for URI: '%s' is not supported", hs.sync()) |
There was a problem hiding this comment.
This retains the current behavior but is inconsistent with the file sync implementation. I'd prefer to return an error if the file extension is invalid or undefined but it would be a breaking change.
Do not merge until a decision has been made on the expected behavior.
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
changed the title
Signed-off-by: Michael Beemer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #1512
How to test
make testormake test-core