fix: selector not being sent in sync call (#1220)

Signed-off-by: Simon Schrottner <[email protected]>
open-feature · Feb 13, 2025 · 99e25ce · 99e25ce
1 parent 34f83c5
commit 99e25ce
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 10 deletions.
diff --git a/.../contrib/providers/flagd/resolver/process/storage/connector/grpc/GrpcStreamConnector.java b/.../contrib/providers/flagd/resolver/process/storage/connector/grpc/GrpcStreamConnector.java
@@ -51,7 +51,16 @@ public GrpcStreamConnector(final FlagdOptions options, Consumer<FlagdProviderEve
                 FlagSyncServiceGrpc::newStub,
                 FlagSyncServiceGrpc::newBlockingStub,
                 onConnectionEvent,
-                stub -> stub.syncFlags(SyncFlagsRequest.getDefaultInstance(), new GrpcStreamHandler(streamReceiver)));
+                stub -> {
+                    String localSelector = selector;
+
+                    final SyncFlagsRequest.Builder syncRequest = SyncFlagsRequest.newBuilder();
+                    if (localSelector != null) {
+                        syncRequest.setSelector(localSelector);
+                    }
+
+                    stub.syncFlags(syncRequest.build(), new GrpcStreamHandler(streamReceiver));
+                });
     }
 
     /** Initialize gRPC stream connector. */
@@ -98,14 +107,9 @@ void observeEventStream(final BlockingQueue<QueuePayload> writeTo, final AtomicB
             Exception metadataException = null;
 
             log.debug("Initializing sync stream request");
-            final SyncFlagsRequest.Builder syncRequest = SyncFlagsRequest.newBuilder();
             final GetMetadataRequest.Builder metadataRequest = GetMetadataRequest.newBuilder();
             GetMetadataResponse metadataResponse = GetMetadataResponse.getDefaultInstance();
 
-            if (selector != null) {
-                syncRequest.setSelector(selector);
-            }
-
             try (CancellableContext context = Context.current().withCancellation()) {
 
                 try {

diff --git a/providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunFileTest.java b/providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunFileTest.java
@@ -28,7 +28,7 @@
 @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "dev.openfeature.contrib.providers.flagd.e2e.steps")
 @ConfigurationParameter(key = OBJECT_FACTORY_PROPERTY_NAME, value = "io.cucumber.picocontainer.PicoFactory")
 @IncludeTags("file")
-@ExcludeTags({"unixsocket", "targetURI", "reconnect", "customCert"})
+@ExcludeTags({"unixsocket", "targetURI", "reconnect", "customCert", "events"})
 @Testcontainers
 public class RunFileTest {
 

diff --git a/...ers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunInProcessTest.java b/...ers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunInProcessTest.java
@@ -24,7 +24,7 @@
 @IncludeEngines("cucumber")
 @SelectDirectories("test-harness/gherkin")
 // if you want to run just one feature file, use the following line instead of @SelectDirectories
-// @SelectFile("test-harness/gherkin/connection.feature")
+// @SelectFile("test-harness/gherkin/selector.feature")
 @ConfigurationParameter(key = PLUGIN_PROPERTY_NAME, value = "pretty")
 @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "dev.openfeature.contrib.providers.flagd.e2e.steps")
 @ConfigurationParameter(key = OBJECT_FACTORY_PROPERTY_NAME, value = "io.cucumber.picocontainer.PicoFactory")

diff --git a/.../flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/ProviderSteps.java b/.../flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/ProviderSteps.java
@@ -40,7 +40,6 @@ public ProviderSteps(State state) {
 
     @BeforeAll
     public static void beforeAll() throws IOException {
-        State.resolverType = Config.Resolver.RPC;
         sharedTempDir = Files.createDirectories(
                 Paths.get("tmp/" + RandomStringUtils.randomAlphanumeric(8).toLowerCase() + "/"));
         container = new FlagdContainer()

diff --git a/providers/flagd/test-harness b/providers/flagd/test-harness