-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(flagd): use newest testbed launchpad #1168
Merged
aepfli
merged 9 commits into
open-feature:main
from
open-feature-forking:feat/update_testharness_to_launchpad
Feb 6, 2025
Merged
test(flagd): use newest testbed launchpad #1168
aepfli
merged 9 commits into
open-feature:main
from
open-feature-forking:feat/update_testharness_to_launchpad
Feb 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaa7b7
to
246c3ff
Compare
chrfwow
approved these changes
Jan 22, 2025
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/FlagdContainer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Simon Schrottner <[email protected]>
246c3ff
to
c84c0de
Compare
Signed-off-by: Simon Schrottner <[email protected]>
4b42608
to
0d3a4ad
Compare
Signed-off-by: Simon Schrottner <[email protected]>
943cacf
to
6020674
Compare
toddbaert
reviewed
Jan 29, 2025
...ers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/ProviderSteps.java
Show resolved
Hide resolved
toddbaert
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to say I love this solution 😍
there seems to be some flakyness in one of the tests... we should investigate before merging, might need help |
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
chrfwow
reviewed
Feb 5, 2025
...ers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/ProviderSteps.java
Outdated
Show resolved
Hide resolved
...ers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/ProviderSteps.java
Show resolved
Hide resolved
beeme1mr
approved these changes
Feb 5, 2025
96a22fc
to
958bfd5
Compare
aepfli
commented
Feb 5, 2025
...gd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/common/ChannelMonitor.java
Show resolved
Hide resolved
dbb4ae1
to
7fdf6df
Compare
…stopping the container Signed-off-by: Simon Schrottner <[email protected]>
7fdf6df
to
f520a29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.