feat: add gRPC keepalive #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
feat/add-grpc-keepalive-option
branch
from
5f46247 to
f5bad17
Compare
Signed-off-by: Todd Baert <[email protected]>
aepfli
approved these changes
Aug 29, 2024
beeme1mr
approved these changes
Aug 29, 2024
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/Config.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
guidobrei
reviewed
Aug 30, 2024
| @@ -105,6 +105,7 @@ Given below are the supported configurations: | |||
| | socketPath | FLAGD_SOCKET_PATH | String | null | rpc & in-process | | |||
| | certPath | FLAGD_SERVER_CERT_PATH | String | null | rpc & in-process | | |||
| | deadline | FLAGD_DEADLINE_MS | int | 500 | rpc & in-process | | |||
| | keepAliveTime | FLAGD_KEEP_ALIVE_TIME | long | 0 | rpc & in-process | | |||
There was a problem hiding this comment.
Can we somewhere document the unit of this value? The deadline clearly states that it is expecting milliseconds in the variable name. Keep-alive does not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds gRPC keepalive.
The according to in-line docs, the keepalive in the netty channel is disabled with Long.MAX_VALUE, so I've mapped that from 0.