fix(flipt): return the correct default value when provided in Flipt (#…

…1052) Signed-off-by: Roman Dmytrenko <[email protected]>
open-feature · Sep 4, 2024 · 28bffa5 · 28bffa5
1 parent 0b6179b
commit 28bffa5
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/libs/providers/flipt/src/lib/flipt-provider.spec.ts b/libs/providers/flipt/src/lib/flipt-provider.spec.ts
@@ -193,6 +193,27 @@ describe('FliptProvider', () => {
       expect(value).toHaveProperty('value', { hello: 'world' });
     });
 
+    it('should return right value for default value', async () => {
+      fetchMock.post(
+        variantEndpoint,
+        {
+          match: false,
+          segmentKeys: [],
+          reason: 'DEFAULT_EVALUATION_REASON',
+          variantKey: '10',
+          variantAttachment: `{"hello": "world"}`,
+          requestId: '0f39483c-d52b-42b4-adbb-40b98bc7058d',
+          requestDurationMillis: 0.409,
+          timestamp: '2024-01-15T18:51:50.629551Z',
+          flagKey: 'flag_json',
+        },
+        { overwriteRoutes: true },
+      );
+
+      const value = await provider.resolveObjectEvaluation('flag_json', {}, { fizz: 'buzz' });
+      expect(value).toHaveProperty('value', { hello: 'world' });
+    });
+
     it('should throw TypeMismatchError on non-number value', async () => {
       fetchMock.post(
         variantEndpoint,

diff --git a/libs/providers/flipt/src/lib/flipt-provider.ts b/libs/providers/flipt/src/lib/flipt-provider.ts
@@ -169,7 +169,7 @@ export class FliptProvider implements Provider {
         };
       }
 
-      if (!variantEvaluation.match) {
+      if (!variantEvaluation.match && variantEvaluation.reason != 'DEFAULT_EVALUATION_REASON') {
         return {
           value: defaultValue,
           reason: StandardResolutionReasons.DEFAULT,