Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go-feature-flag): Support endpoint paths in data collector goff-api.ts #1184

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

crprice
Copy link
Contributor

@crprice crprice commented Jan 16, 2025

This PR

How to test

  • Instantiate web provider with endpoint like https://some.website/examplepath
  • Check data collector calls go to https://some.website/examplepath/v1/data/collector

@crprice crprice requested a review from a team as a code owner January 16, 2025 19:35
@crprice crprice changed the title Support endpoint paths in data collector goff-api.ts fix: Support endpoint paths in data collector goff-api.ts Jan 16, 2025
Copy link
Member

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crprice thanks for catching this.
Would it be possible to add a unit test for this?
If you don't have time let me know and I can help writing it.

…collector goff-api.ts goff-api.spec.ts

Signed-off-by: Chris Price <[email protected]>
@crprice
Copy link
Contributor Author

crprice commented Jan 22, 2025

@crprice thanks for catching this. Would it be possible to add a unit test for this? If you don't have time let me know and I can help writing it.

@thomaspoignant I submitted a commit for the unit test. Does that work for you? Also, I thank you for your implementations of the open feature specification. It's really great work.

@thomaspoignant thomaspoignant changed the title fix: Support endpoint paths in data collector goff-api.ts fix(go-feature-flag): Support endpoint paths in data collector goff-api.ts Jan 23, 2025
@thomaspoignant
Copy link
Member

Thanks for the test this is perfect.
I will release a new version today including this fix.

@thomaspoignant thomaspoignant merged commit 928e437 into open-feature:main Jan 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants