feat: export useOpenFeatureClientStatus hook #1082
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wichopy
force-pushed
the
issue-1036
branch
2 times, most recently
from
8172213 to
f1ff607
Compare
wichopy
commented
Nov 10, 2024
wichopy
changed the title
wichopy
commented
Nov 10, 2024
toddbaert
reviewed
Dec 17, 2024
toddbaert
reviewed
Dec 17, 2024
|
@wichopy Sorry for the delay - KubeCon really slowed things down for us, still playing some catch-up! I still think this is valuable, and I think you're on the right track. I left some thoughts. We also need some tests (probably very similar to the other tests involving hooks and suspense). |
toddbaert
requested review from
beeme1mr,
aepfli,
toddbaert,
tjosepo,
lukas-reining and
guidobrei
Signed-off-by: William Chou <[email protected]> Signed-off-by: Will Chou <[email protected]>
Signed-off-by: William Chou <[email protected]> Signed-off-by: Will Chou <[email protected]>
Signed-off-by: Will Chou <[email protected]>
Signed-off-by: Will Chou <[email protected]>
Signed-off-by: Will Chou <[email protected]>
Signed-off-by: Will Chou <[email protected]>
beeme1mr
changed the title
beeme1mr
approved these changes
Jan 2, 2025
Signed-off-by: Will Chou <[email protected]>
Signed-off-by: Will Chou <[email protected]>
lukas-reining
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
exposes the internal open feature client status hook so developers can act on non-ready resolved states
Related Issues
Fixes #1036
Notes
Follow-up Tasks
How to test