Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make hooks in client sdk only return void #671

Merged
merged 10 commits into from
Nov 21, 2023
Merged

fix: make hooks in client sdk only return void #671

merged 10 commits into from
Nov 21, 2023

Conversation

lukas-reining
Copy link
Member

This PR

Fixes return type of hooks in client SDK.

Maybe we should make this more clear in the spec @toddbaert.

Related Issues

Fixes #630

Notes

Follow-up Tasks

How to test

@lukas-reining lukas-reining requested a review from a team as a code owner November 20, 2023 10:42
beeme1mr
beeme1mr reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I want to manually test before I approve. The change was bigger than I expected 😄

@lukas-reining
Copy link
Member Author

This looks good but I want to manually test before I approve. The change was bigger than I expected 😄

Thanks! Well It was not much but the hook types just touched many files.
And many of these were not formatted with the attached prettier which is why this might seem a bit verbose.

lukas-reining and others added 4 commits November 21, 2023 15:08
@lukas-reining @toddbaert
Update packages/server/src/client/open-feature-client.ts
26e517d 
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Lukas Reining <[email protected]>
@lukas-reining @toddbaert
Update packages/server/src/evaluation/evaluation.ts
16dea31 
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Lukas Reining <[email protected]>
@lukas-reining @toddbaert
Update packages/server/src/provider/provider.ts
fa7d232 
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Lukas Reining <[email protected]>
@lukas-reining @toddbaert
Update packages/server/test/hooks.spec.ts
40c3d4c 
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Lukas Reining <[email protected]>
@lukas-reining @toddbaert
Update packages/client/src/open-feature.ts
239dd9b 
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Lukas Reining <[email protected]>
lukas-reining and others added 2 commits November 21, 2023 15:18
@lukas-reining @toddbaert
Update packages/server/src/open-feature.ts
5ad5d3e 
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Lukas Reining <[email protected]>
@lukas-reining @toddbaert
Update packages/client/src/provider/provider.ts
2c5afd6 
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Lukas Reining <[email protected]>
toddbaert
toddbaert approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Besides the imports, I made this comment, which is just an interesting observation.

@toddbaert toddbaert requested a review from beeme1mr November 21, 2023 14:23
@toddbaert
Copy link
Member

@lukas-reining I'm sure one of my import changes broke the build, I was only doing them in github. I guess that in general you should be able to import from the barrel files though. 😅

@lukas-reining
Cleanup imports
06f7410 
Signed-off-by: Lukas Reining <[email protected]>
@lukas-reining
Copy link
Member Author

@lukas-reining I'm sure one of my import changes broke the build, I was only doing them in github. I guess that in general you should be able to import from the barrel files though. 😅

Fixed, it was one of them missing a dot 😅 Good observation.

@toddbaert
Copy link
Member

Oh, I should also mention, I packaged this locally and linked it in the js-contribs: everything built fine there, so exports/types/etc seem good. cc @beeme1mr

beeme1mr
beeme1mr approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the API doc generation as well. Looks good to me. Thank you @lukas-reining 🙇

@beeme1mr beeme1mr added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit a7d0b95 Nov 21, 2023
7 checks passed
@beeme1mr beeme1mr deleted the fix/wrong-hook-return-type branch November 21, 2023 16:31
This was referenced Nov 21, 2023
Merged
Merged
Merged
toddbaert added a commit that referenced this pull request Nov 21, 2023
@openfeaturebot @toddbaert
chore(main): release core 0.0.19 (#676)
b0cbeb4 
🤖 I have created a release *beep* *boop*
---


##
[0.0.19](core-v0.0.18...core-v0.0.19)
(2023-11-21)


### 🐛 Bug Fixes

* make hooks in client sdk only return void
([#671](#671))
([a7d0b95](a7d0b95))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: openfeature-peer-update-bot <[email protected]>
Co-authored-by: openfeature-peer-update-bot <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
toddbaert pushed a commit that referenced this pull request Nov 21, 2023
@openfeaturebot
chore(main): release web-sdk 0.4.6 (#675)
69d2c88 
🤖 I have created a release *beep* *boop*
---


##
[0.4.6](web-sdk-v0.4.5...web-sdk-v0.4.6)
(2023-11-21)


### 🐛 Bug Fixes

* make hooks in client sdk only return void
([#671](#671))
([a7d0b95](a7d0b95))


### ✨ New Features

* client in memory provider
([#617](#617))
([6051dfd](6051dfd))


### 🧹 Chore

* **main:** release core 0.0.19
([#676](#676))
([b0cbeb4](b0cbeb4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
This was referenced Mar 12, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@toddbaert toddbaert toddbaert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Web SDK hooks can return a promise?
3 participants
@lukas-reining @toddbaert @beeme1mr