Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong context passed to named providers #752

Merged
merged 3 commits into from
Jan 11, 2024
Merged

fix: wrong context passed to named providers #752

merged 3 commits into from
Jan 11, 2024

Conversation

toddbaert
Copy link
Member

Fixed an issue with implementations of #704 where the wrong context was passed to namespaced providers.

@toddbaert toddbaert requested a review from a team as a code owner January 10, 2024 18:30
@toddbaert toddbaert changed the title fix: wrong context passed to named provider fix: wrong context passed to named providers Jan 11, 2024
lukas-reining
lukas-reining approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

beeme1mr
beeme1mr approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but I do think you should add an additional test. We're not sufficiently covering the evaluation process when using namespaced evaluation context.

@toddbaert
Copy link
Member Author

Approving but I do think you should add an additional test. We're not sufficiently covering the evaluation process when using namespaced evaluation context.

Agreed I think it should be simple to add another.

@toddbaert
fixup: add test
7816e50 
Signed-off-by: Todd Baert <[email protected]>
@toddbaert
fixup: lint
0fa83db 
Signed-off-by: Todd Baert <[email protected]>
@toddbaert toddbaert added this pull request to the merge queue Jan 11, 2024
Merged via the queue into main with commit b6adbba Jan 11, 2024
8 checks passed
@toddbaert toddbaert deleted the fix/wrong-context-passed branch January 11, 2024 17:21
@openfeaturebot openfeaturebot mentioned this pull request Jan 11, 2024
Merged
toddbaert added a commit that referenced this pull request Jan 11, 2024
@openfeaturebot @toddbaert
chore(main): release web-sdk 0.4.10 (#754)
58cac6c 
🤖 I have created a release *beep* *boop*
---


##
[0.4.10](web-sdk-v0.4.9...web-sdk-v0.4.10)
(2024-01-11)


### 🐛 Bug Fixes

* some handlers fail to run
([#753](#753))
([f4597af](f4597af))
* wrong context passed to named providers
([#752](#752))
([b6adbba](b6adbba))


### 🧹 Chore

* **main:** release core 0.0.23
([#755](#755))
([da478cb](da478cb))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@lukas-reining lukas-reining lukas-reining approved these changes

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

@luizbon luizbon Awaiting requested review from luizbon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toddbaert @beeme1mr @lukas-reining