Skip to content

Commit

Permalink
chore: update to tracing hook, fix nx:serve (#235)
Browse files Browse the repository at this point in the history
See title

Signed-off-by: Todd Baert <[email protected]>
  • Loading branch information
toddbaert authored Jul 12, 2023
1 parent 566e96d commit 868214f
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 14 deletions.
20 changes: 10 additions & 10 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@openfeature/flagd-web-provider": "^0.3.4",
"@openfeature/go-feature-flag-provider": "^0.5.3",
"@openfeature/js-sdk": "^1.3.1",
"@openfeature/open-telemetry-hook": "^6.0.0",
"@openfeature/open-telemetry-hooks": "^0.2.1",
"@openfeature/web-sdk": "^0.3.4-experimental",
"@opentelemetry/api": "~1.4.0",
"@opentelemetry/auto-instrumentations-node": "^0.36.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/app/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
]
},
"serve": {
"executor": "@nx/node:node",
"executor": "@nx/js:node",
"options": {
"buildTarget": "app:build",
"runtimeArgs": ["-r", "./scripts/tracing.js"]
Expand Down
4 changes: 2 additions & 2 deletions packages/app/src/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { REQUEST } from '@nestjs/core';
import { ServeStaticModule } from '@nestjs/serve-static';
import { AsyncLocalStorageTransactionContext, LoggingHook, OpenFeatureLogger } from '@openfeature/extra';
import { OpenFeature } from '@openfeature/js-sdk';
import { OpenTelemetryHook } from '@openfeature/open-telemetry-hook';
import { TracingHook } from '@openfeature/open-telemetry-hooks';
import { ProviderService } from '@openfeature/provider';
import { Request } from 'express';
import { Agent } from 'http';
Expand All @@ -27,7 +27,7 @@ OpenFeature.setLogger(new OpenFeatureLogger('OpenFeature'));
* Adding hooks to at the global level will ensure they always run
* as part of a flag evaluation lifecycle.
*/
OpenFeature.addHooks(new LoggingHook(), new OpenTelemetryHook());
OpenFeature.addHooks(new LoggingHook(), new TracingHook());

/**
* The transaction context propagator is an experimental feature
Expand Down

0 comments on commit 868214f

Please sign in to comment.